Skip to content

Conversation

@hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented May 19, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

@hameerabbasi hameerabbasi requested a review from mtsokol May 19, 2025 12:19
mtsokol
mtsokol previously approved these changes May 19, 2025
Copy link
Collaborator

@mtsokol mtsokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Numba CI job is green - LGTM!

@hameerabbasi hameerabbasi force-pushed the increase-array-api-coverage branch 2 times, most recently from 8077f8f to ccedc21 Compare May 19, 2025 12:35
@hameerabbasi hameerabbasi force-pushed the increase-array-api-coverage branch from ccedc21 to 928dfc1 Compare May 19, 2025 12:35
@hameerabbasi hameerabbasi changed the title Increase support of array API standard. feat, fix: Increase support of array API standard. May 19, 2025
@github-actions github-actions bot added the enhancement Indicates new feature requests label May 19, 2025
@hameerabbasi hameerabbasi added the bug Indicates an unexpected problem or unintended behavior label May 19, 2025
@hameerabbasi
Copy link
Collaborator Author

Merging based on #873 (review) and the fact that the Finch array API tests are currently broken.

@hameerabbasi hameerabbasi merged commit 9988853 into pydata:main May 19, 2025
19 of 22 checks passed
@hameerabbasi hameerabbasi deleted the increase-array-api-coverage branch May 19, 2025 12:50
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #873 will not alter performance

Comparing hameerabbasi:increase-array-api-coverage (928dfc1) with main (79c1a17)

Summary

βœ… 340 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Indicates an unexpected problem or unintended behavior enhancement Indicates new feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants